Thread (19 messages) 19 messages, 6 authors, 2016-03-18

Re: [v3,1/8] powerpc: Create a helper for getting the kernel toc value

From: Jiri Kosina <jikos@kernel.org>
Date: 2016-03-15 01:27:11
Also in: linuxppc-dev

On Mon, 14 Mar 2016, Michael Ellerman wrote:
quoted
Move the logic to work out the kernel toc pointer into a header. This is
a good cleanup, and also means we can use it elsewhere in future.

Reviewed-by: Kamalesh Babulal <redacted>
Reviewed-by: Torsten Duwe <redacted>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Tested-by: Kamalesh Babulal <redacted>
Series applied to powerpc next.

https://git.kernel.org/powerpc/c/a5cab83cd3d2d75d3893276cb5
Thanks Michael; this is an excellent basis for ppc live patching, but FYI 
I am not merging that one to my tree just yet.

The solution (*) for functions with non-trivial argument list is not there 
yet, and it's my requirement for this to be taken care of in a way that's 
not prone to easily-done human errors on the patch-producer side.

(*) both "making it work" or "making it so broken that it's guaranteed 
    that noone would ever produce a patch that brings the kernel down" is 
    okay, but I really don't feel that just documenting the limitation is
    sufficient and safe in this case; kudos to Torsten here for
    idenfitfying the problem before it actually became The Problem

Thanks,

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help