Re: [PATCH v6 04/19] arm64: change some CONFIG_COMPAT over to use CONFIG_AARCH32_EL0 instead

On Thu, Dec 03, 2015 at 12:02:27PM +0000, Catalin Marinas wrote:

On Wed, Nov 18, 2015 at 12:16:44AM +0300, Yury Norov wrote:

quoted

From: Andrew Pinski <redacted>

Reviewed-by: David Daney <redacted>

Signed-off-by: Philipp Tomsich <redacted>
Signed-off-by: Christoph Muellner <redacted>
Signed-off-by: Yury Norov <redacted>
Signed-off-by: Andrew Pinski <redacted>

Please add a long description to every patch, even if it is trivial.

And a nitpick: remove the empty lines between Reviewed-by and
Signed-off-by. These tags usually come in the same block.

quoted

+#else
+
+typedef elf_greg_t			compat_elf_greg_t;
+typedef elf_gregset_t			compat_elf_gregset_t;
+#define compat_a32_elf_check_arch(x)	0
+#define COMPAT_SET_PERSONALITY(ex)
+#define COMPAT_ARCH_DLINFO
+
+#endif

Do you need these definitions here? I guess they may be used later by
the ILP32 code paths but for A32 compat they don't make much sense (I
haven't made it to the end of the series yet).

It should have been attached to patch "support core dump generation for
ILP32". I'll fix.

-- 
Catalin