On Sun, 2015-09-06 at 01:37 -0500, Zhao Qiang-B45475 wrote:

On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote:

quoted

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 02, 2015 8:34 AM
To: Zhao Qiang-B45475
Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
lauraa@codeaurora.org; Xie Xiaobo-R63061; benh@kernel.crashing.org; Li
Yang-Leo-R58472; paulus@samba.org
Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage
muram

On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:

quoted

@@ -187,12 +190,25 @@ static inline int qe_alive_during_sleep(void)  }

 /* we actually use cpm_muram implementation, define this for

convenience */ -#define qe_muram_init cpm_muram_init -#define
qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed
cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free -#define
qe_muram_addr cpm_muram_addr -#define qe_muram_offset cpm_muram_offset
+#define cpm_muram_init qe_muram_init
+#define cpm_muram_alloc qe_muram_alloc #define cpm_muram_alloc_fixed
+qe_muram_alloc_fixed #define cpm_muram_free qe_muram_free #define
+cpm_muram_addr qe_muram_addr #define cpm_muram_offset qe_muram_offset

Why?  This is unnecessary churn.

This is necessary. QE is on both ARM and PowerPC, its code is under public 
code.
But CPM is only on PowerPC and its code is under PowerPC.
So when build ARM, QE will not find cpm_muram_* function.

If you move the cpm_muram functions to drivers/soc, then ARM will find them.  
There is no need to rename them.

-Scott