Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts()

[PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Steven Rostedt <rostedt@goodmis.org> · 2014-09-26
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Petr Mladek <hidden> · 2014-09-29
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Steven Rostedt <rostedt@goodmis.org> · 2014-09-29
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Joe Perches <joe@perches.com> · 2014-09-29
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Steven Rostedt <rostedt@goodmis.org> · 2014-09-29
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Petr Mladek <hidden> · 2014-09-29
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Steven Rostedt <rostedt@goodmis.org> · 2014-09-29
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Al Viro <viro@ZenIV.linux.org.uk> · 2014-09-29
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Joe Perches <joe@perches.com> · 2014-09-29
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Steven Rostedt <rostedt@goodmis.org> · 2014-09-29
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Joe Perches <joe@perches.com> · 2014-09-29
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Steven Rostedt <rostedt@goodmis.org> · 2014-09-29
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Joe Perches <joe@perches.com> · 2014-09-29
[PATCH 0/7] seq_printf cleanups · Joe Perches <joe@perches.com> · 2014-09-29
[PATCH 1/7] seq_file: Rename static bool seq_overflow to public bool seq_is_full · Joe Perches <joe@perches.com> · 2014-09-29
Re: [PATCH 1/7] seq_file: Rename static bool seq_overflow to public bool seq_is_full · Steven Rostedt <rostedt@goodmis.org> · 2014-09-29
Re: [PATCH 1/7] seq_file: Rename static bool seq_overflow to public bool seq_is_full · Joe Perches <joe@perches.com> · 2014-09-29
Re: [PATCH 1/7] seq_file: Rename static bool seq_overflow to public bool seq_is_full · Petr Mladek <hidden> · 2014-09-30
[PATCH 5/7] fs: Convert show_fdinfo functions to void · Joe Perches <joe@perches.com> · 2014-09-29
Re: [PATCH 5/7] fs: Convert show_fdinfo functions to void · Steven Rostedt <rostedt@goodmis.org> · 2014-10-28
Re: [PATCH 5/7] fs: Convert show_fdinfo functions to void · Joe Perches <joe@perches.com> · 2014-10-28
Re: [PATCH 5/7] fs: Convert show_fdinfo functions to void · Steven Rostedt <rostedt@goodmis.org> · 2014-10-28
[PATCH 2/7] netfilter: Convert print_tuple functions to return void · Joe Perches <joe@perches.com> · 2014-09-29
Re: [PATCH 2/7] netfilter: Convert print_tuple functions to return void · Petr Mladek <hidden> · 2014-09-30
Re: [PATCH 2/7] netfilter: Convert print_tuple functions to return void · Joe Perches <joe@perches.com> · 2014-09-30
[PATCH 3/7] dlm: Use seq_is_full - remove seq_printf returns · Joe Perches <joe@perches.com> · 2014-09-29
Re: [PATCH 3/7] dlm: Use seq_is_full - remove seq_printf returns · Petr Mladek <hidden> · 2014-09-30
Re: [PATCH 3/7] dlm: Use seq_is_full - remove seq_printf returns · Steven Rostedt <rostedt@goodmis.org> · 2014-10-27
Re: [PATCH 3/7] dlm: Use seq_is_full - remove seq_printf returns · Joe Perches <joe@perches.com> · 2014-10-27
Re: [PATCH 3/7] dlm: Use seq_is_full - remove seq_printf returns · Petr Mladek <hidden> · 2014-10-29
[PATCH 6/7] debugfs: Fix misuse of seq_printf return value · Joe Perches <joe@perches.com> · 2014-09-29
Re: [PATCH 6/7] debugfs: Fix misuse of seq_printf return value · Steven Rostedt <rostedt@goodmis.org> · 2014-10-28
Re: [PATCH 6/7] debugfs: Fix misuse of seq_printf return value · Joe Perches <joe@perches.com> · 2014-10-28
Re: [PATCH 6/7] debugfs: Fix misuse of seq_printf return value · Steven Rostedt <rostedt@goodmis.org> · 2014-10-28
Re: [PATCH 6/7] debugfs: Fix misuse of seq_printf return value · Joe Perches <joe@perches.com> · 2014-10-28
Re: [PATCH 6/7] debugfs: Fix misuse of seq_printf return value · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2014-11-07
[PATCH 7/7] docg3: Fix miuse of seq_printf return value · Joe Perches <joe@perches.com> · 2014-09-29
Re: [PATCH 7/7] docg3: Fix miuse of seq_printf return value · Brian Norris <computersforpeace@gmail.com> · 2014-10-22
Re: [PATCH 7/7] docg3: Fix miuse of seq_printf return value · Steven Rostedt <rostedt@goodmis.org> · 2014-10-28
Re: [PATCH 7/7] docg3: Fix miuse of seq_printf return value · Joe Perches <joe@perches.com> · 2014-10-28
Re: [PATCH 7/7] docg3: Fix miuse of seq_printf return value · Steven Rostedt <rostedt@goodmis.org> · 2014-10-28
Re: [PATCH 7/7] docg3: Fix miuse of seq_printf return value · Brian Norris <computersforpeace@gmail.com> · 2014-10-28
Re: [PATCH 7/7] docg3: Fix miuse of seq_printf return value · Steven Rostedt <rostedt@goodmis.org> · 2014-10-28
Re: [PATCH 7/7] docg3: Fix miuse of seq_printf return value · Joe Perches <joe@perches.com> · 2014-10-28
Re: [PATCH 7/7] docg3: Fix miuse of seq_printf return value · Steven Rostedt <rostedt@goodmis.org> · 2014-10-28
Re: [PATCH 7/7] docg3: Fix miuse of seq_printf return value · Brian Norris <computersforpeace@gmail.com> · 2014-10-28
Re: [PATCH 7/7] docg3: Fix miuse of seq_printf return value · Joe Perches <joe@perches.com> · 2014-10-28
[PATCH 4/7] dlm: Use seq_puts, remove unnecessary trailing spaces · Joe Perches <joe@perches.com> · 2014-09-29
Re: [PATCH 0/7] seq_printf cleanups · Steven Rostedt <rostedt@goodmis.org> · 2014-10-28
Re: [PATCH 0/7] seq_printf cleanups · Joe Perches <joe@perches.com> · 2014-10-28
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Joe Perches <joe@perches.com> · 2014-10-06
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Steven Rostedt <rostedt@goodmis.org> · 2014-09-29
Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() · Al Viro <viro@ZenIV.linux.org.uk> · 2014-09-29

From: Joe Perches <joe@perches.com>
Date: 2014-09-29 16:08:07

On Mon, 2014-09-29 at 16:47 +0100, Al Viro wrote:

On Mon, Sep 29, 2014 at 04:41:22PM +0200, Petr Mladek wrote:

quoted

Hmm, this inconsistency seems to be in more functions. I would divide
it into three categories:

[]

No.  _Any_ caller that decides to report that error to its caller is fucking
broken.  We had some cases like that.

[]

And let's make seq_printf and friends return void.  Any breakage we miss
on grep will be caught by compiler.  Enough is enough.

https://lkml.org/lkml/2013/12/11/8

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help