Re: [PATCH v2 01/15] KVM: MMU: fix the count of spte number

On Sep 8, 2013, at 10:01 PM, Gleb Natapov [off-list ref] wrote:

On Sun, Sep 08, 2013 at 09:55:04PM +0800, Xiao Guangrong wrote:

quoted

On Sep 8, 2013, at 8:19 PM, Gleb Natapov [off-list ref] wrote:

quoted

On Thu, Sep 05, 2013 at 06:29:04PM +0800, Xiao Guangrong wrote:

quoted

If the desc is the last one and it is full, its sptes is not counted

Hmm, if desc is not full but it is not the last one all sptes after the
desc are not counted too.

But the desc must be the last one if it's not full since we always add
new entry or delete entry from the last desc.

Why do we alway delete entries from last desc? We delete them from the
desc we found them in. Current code does not try to move entries between
descs, only inside a desc.

Oh, yes. Sorry, my memory is wrong… :(

So, currently there has some gaps in desc and it wastes memory.  Can not fix
them with simple change and  i think it is not worthy to fix them separately since
after my new algorithm, these should all be fixed… so how about just drop this
fix?