-----Original Message-----
From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
owner@vger.kernel.org] On Behalf Of Patil, Rachna
Sent: Friday, September 14, 2012 10:29 AM
To: Lars-Peter Clausen
Cc: linux-kernel@vger.kernel.org; linux-input@vger.kernel.org; linux-
iio@vger.kernel.org; Samuel Ortiz; Dmitry Torokhov; Dmitry Torokhov;
Jonathan Cameron
Subject: RE: [PATCH v3 5/5] MFD: ti_tscadc: add suspend/resume
functionality

On Thu, Sep 13, 2012 at 18:31:35, Lars-Peter Clausen wrote:

quoted

On 09/13/2012 12:40 PM, Patil, Rachna wrote:

quoted

This patch adds support for suspend/resume of TSC/ADC MFDevice.

Signed-off-by: Patil, Rachna <redacted>
---
Changes in v2:
	Added this patch newly in this patch series.

Changes in v3:
	No changes.

 drivers/iio/adc/ti_adc.c           |   32

++++++++++++++++++++++++++++++++

quoted

quoted

 drivers/input/touchscreen/ti_tsc.c |   33

+++++++++++++++++++++++++++++++++

quoted

quoted

 drivers/mfd/ti_tscadc.c            |   33

++++++++++++++++++++++++++++++++-

quoted

quoted

 include/linux/mfd/ti_tscadc.h      |    3 +++
 4 files changed, 100 insertions(+), 1 deletions(-)

diff --git a/drivers/iio/adc/ti_adc.c b/drivers/iio/adc/ti_adc.c index

56f8af2..69f19f0 100644

--- a/drivers/iio/adc/ti_adc.c
+++ b/drivers/iio/adc/ti_adc.c

@@ -207,6 +207,36 @@ static int __devexit tiadc_remove(struct

platform_device *pdev)

quoted

quoted

 	return 0;
 }

[...]

quoted

 static struct platform_driver tiadc_driver = {
 	.driver = {
 		.name   = "tiadc",

@@ -214,6 +244,8 @@ static struct platform_driver tiadc_driver = {
 	},
 	.probe	= tiadc_probe,
 	.remove	= __devexit_p(tiadc_remove),
+	.suspend = adc_suspend,
+	.resume = adc_resume,
 };

Using the suspend/resume callbacks is deprecated, please use

dev_pm_ops.

quoted

Same comment applies to the other two drivers.

Ok. I will make changes in all the 3 driver to use dev_pm_ops instead of
suspend/resume callbacks.

Probably you might need to protect suspend/resumes with CONFIG_PM. 

Regards,
Rachna

quoted

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/