Thread (16 messages) 16 messages, 3 authors, 2012-06-18

Re: [PATCH 04/10] fblog: implement fblog_redraw()

From: David Herrmann <hidden>
Date: 2012-06-18 18:36:52
Also in: linux-fbdev, linux-serial

Hi Alan

On Sun, Jun 17, 2012 at 12:35 AM, Alan Cox [off-list ref] wrote:
On Sun, 17 Jun 2012 00:04:20 +0200
David Herrmann [off-list ref] wrote:
quoted
This mostly copies the functionality from drivers/video/console/bitblit.c
so we can draw the console content on all available framebuffers.

All speed optimizations have been removed for simplicity. The original
code depends heavily on CONFIG_VT so we cannot share the codebase here.
No. That means we've got two sets of code to maintain not one. Fix the
dependancy.

Pull the relevant subset of struct vc_data into another struct
Make struct vc_data be

struct vc_data {
       struct vc_whatever
       rest
}
It's a bit more complex as we cannot call scr_read() either. Hence, I
need to assemble the array of printed characters before calling the
redraw functions. But that should be feasible, too. I just need to
figure out how to avoid heavy allocations during redraw to avoid
slowdowns.

If there are no objections I will send these patches as a separate
patchset as we can apply it without fblog.
Alan
Thanks for reviewing
David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help