Re: [PATCH 3/5] x86: s/#if CONFIG/#ifdef CONFIG/
From: Ingo Molnar <hidden>
Date: 2012-02-20 08:26:04
* Geert Uytterhoeven [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Cc: "H. Peter Anvin" <hpa@zytor.com>" Cc: Thomas Gleixner <redacted> Cc: Ingo Molnar <mingo@redhat.com> Cc: x86@kernel.org --- arch/x86/boot/compressed/head_32.S | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/arch/x86/boot/compressed/head_32.S b/arch/x86/boot/compressed/head_32.S index a055993..a37b117 100644 --- a/arch/x86/boot/compressed/head_32.S +++ b/arch/x86/boot/compressed/head_32.S@@ -173,7 +173,7 @@ relocated: call decompress_kernel addl $20, %esp -#if CONFIG_RELOCATABLE +#ifdef CONFIG_RELOCATABLE /* * Find the address of the relocations. */
I'd really prefer to read an actual "this is safe, because this value is defined in the Kconfig as ..." type of commit log instead of nothing, which would ensure us that you didnt just do a (fundamentally unsafe) sed job over the kernel tree but actually have *read* the Kconfig entries in question to ensure the correctness of your patches... Thanks, Ingo