Re: [PATCH v4] Input: Add EVIOC mechanism for MT slots
From: Chase Douglas <hidden>
Date: 2012-02-06 18:26:25
Also in:
linux-input
From: Chase Douglas <hidden>
Date: 2012-02-06 18:26:25
Also in:
linux-input
On 02/06/2012 09:05 AM, Henrik Rydberg wrote:
This patch adds the ability to extract MT slot data via a new ioctl,
EVIOCGMTSLOTS. The function returns an array of slot values for the
specified ABS_MT event type.
Example of user space usage:
struct { unsigned code; int values[64]; } req;
req.code = ABS_MT_POSITION_X;
if (ioctl(fd, EVIOCGMTSLOTS(sizeof(req)), &req) < 0)
return -1;
for (i = 0; i < 64; i++)
printf("slot %d: %d\n", i, req.values[i]);
Signed-off-by: Henrik Rydberg <redacted>
---
Here is the fourth version of the patch.
Rather than over-specifying the ioctl binary format by introducing a
struct object that does not fit everyone, this version simply leaves
all object definitions to userland.This is fine with me. I think the ioctl macro definition would be easier to work with if it took the number of values instead of the size of the request, but it's a nit-pick. If Dmitry thinks this is good enough, it's good enough for me too :). Reviewed-by: Chase Douglas <redacted> Thanks!