Re: Add Dell Studio 1557 to pci=nocrs blacklist

On Wed, Jan 4, 2012 at 11:37 AM, Ingo Molnar [off-list ref] wrote:

* Dave Jones [off-list ref] wrote:

quoted

The Dell Studio 1557 also doesn't suspend correctly when CRS is enabled.
Details at https://bugzilla.redhat.com/show_bug.cgi?id=769657

Reported-by: Gregory S. Hoerner <redacted>
Signed-off-by: Dave Jones <redacted>

--- linux-3.1.noarch/arch/x86/pci/acpi.c~     2012-01-04 11:19:36.783664477 -0500
+++ linux-3.1.noarch/arch/x86/pci/acpi.c      2012-01-04 11:23:42.403666272 -0500

@@ -75,6 +75,16 @@ static const struct dmi_system_id pci_us

      /* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
      {
              .callback = set_nouse_crs,
+             .ident = "Dell Studio 1557",
+             .matches = {
+                     DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
+                     DMI_MATCH(DMI_PRODUCT_NAME, "Studio 1557");
+                     DMI_MATCH(DMI_BIOS_VERSION, "A09"),

Btw., should we perhaps match on all things 'Studio*'? For these
two systems i'm sure there's 20 other models we have not covered
yet ...

+linux-pci

I think we should hold off on merging this patch upstream.  We don't
understand the root cause yet, and I haven't seen any evidence that
setting "pci=nocrs" actually makes a difference in PCI resource
allocation (https://bugzilla.redhat.com/show_bug.cgi?id=769657#c27)

Bjorn