Thread (74 messages) 74 messages, 10 authors, 2011-09-07

Re: [PATCH 6/6] Input: elantech - add v3 hardware support

From: JJ Ding <hidden>
Date: 2011-08-22 00:53:00
Also in: linux-input

Hi Seth,

On Fri, 19 Aug 2011 07:13:08 -0500, Seth Forshee [off-list ref] wrote:
On Fri, Aug 19, 2011 at 04:29:57PM +0800, JJ Ding wrote:
quoted
quoted
You should only report the ABS_[XY] coordinates when fingers != 0. The
xorg synaptics module sees the values reported in that case as
legitimate. This is causing me to see strange behaviors when scrolling
with two-finger drags.
AFAIK, though v2 and v3 differ in packet format, they really report the
same data to the userspace. In this version of v3 support, I even try to
make v2 and v3 report all the data in the same sequnce. If you're seeing
this issue, maybe we should do the same with v2?
Actually neither v1 nor v2 reports ABS_[XY] unless fingers != 0. In v2
the reporting is in a switch statement on the number of fingers, and 0
is unhandled.
Yes, You are right. Sorry I misread your reply about this. I will fix
this as you suggested.

jj
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help