Re: [linux-usb-devel] [PATCH] Fix NEC OHCI chip silicon bug
From: Alan Stern <stern@rowland.harvard.edu>
Date: 2007-06-01 14:20:20
On Thu, 31 May 2007, Michael Hanselmann wrote:
This patch fixes a silicon bug in some NEC OHCI chips. The bug appears at random times and is very, very difficult to reproduce. Without the following patch, Linux would shut the chip and its associated devices down. In Apple PowerBooks this leads to an unusable keyboard and mouse (SSH still working). The idea of restarting the chip is taken from public Darwin code.
quoted hunk ↗ jump to hunk
@@ -779,7 +790,11 @@ static int ohci_restart (struct ohci_hcd */ spin_lock_irq(&ohci->lock); disable (ohci); + +#ifdef CONFIG_PM usb_root_hub_lost_power(ohci_to_hcd(ohci)->self.root_hub); +#endif +
Suppose CONFIG_PM isn't defined. How are you going to let usbcore know about all the old connections which no longer exist? Alan Stern