On 9/1/05, Brett Russ [off-list ref] wrote:
More (non-functional) style modifications since the version 0.11
driver I sent out earlier today. Removed most parens around return
value,
return is not a function call; you can safely remove them all.
+ return ((void __iomem *)((unsigned long)port_mmio &
+ (unsigned long)SATAHC_MASK));
+ return (base + MV_SATAHC0_REG_BASE + (hc * MV_SATAHC_REG_SZ));
+ return (mv_hc_base(base, port >> MV_PORT_HC_SHIFT) +
+ MV_SATAHC_ARBTR_REG_SZ +
+ ((port & MV_PORT_MASK) * MV_PORT_REG_SZ));
+ return ((flags & MV_FLAG_DUAL_HC) ? 2 : 1);
+ return (EDMA_EN & readl(port_mmio + EDMA_CMD_OFS));
+ return (ap->flags & MV_FLAG_BDMA);
Ray