Thread (3 messages) flat view 3 messages, 2 authors, 2d ago

Re: [PATCH] objtool/klp: Fix missed changes to same-named symbol references

From: Longjun Luo <hidden>
Date: 2026-09-10 09:32:25
Also in: lkml, sashiko-reviews

Before this change, __checksum_update_object() received sym_offset but only
used it for debugging output without hashing it.
At this patch's base commit (50d05c7c76c9), __checksum_update_object()
begins with:

        __checksum_update(sym, &offset, sizeof(offset));
        __checksum_update(sym, data, size);

__checksum_update_object_symbol() preserves the same offset handling,
including the unsigned long type and sizeof(offset). The difference is
how the referenced symbol's identity is encoded.

The same &offset/sizeof(offset) pattern is also used in
checksum_update_insn(). Any host-width dependence here therefore
predates this patch.

Thanks,
Longjun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help