Re: [RFC PATCH bpf-next v2 1/2] ftrace: deprecate disabling via ftrace_enabled sysctl
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2026-08-06 01:54:47
Also in:
bpf, linux-doc, linux-kselftest, linux-trace-kernel, stable
On Fri, 31 Jul 2026 13:53:57 -0400 Andrey Grodzovsky [off-list ref] wrote:
quoted hunk ↗ jump to hunk
-static void ftrace_shutdown_sysctl(void) +static void __maybe_unused ftrace_shutdown_sysctl(void) { int command;@@ -9377,7 +9377,7 @@ static void ftrace_shutdown_sysctl(void) # define ftrace_shutdown_sysctl() do { } while (0) #endif /* CONFIG_DYNAMIC_FTRACE */ -static bool is_permanent_ops_registered(void) +static bool __maybe_unused is_permanent_ops_registered(void) { struct ftrace_ops *op;
I agree with Sashiko: https://sashiko.dev/#/patchset/20260731175358.3542156-3-andrey.grodzovsky%40crowdstrike.com Instead of marking with "__maybe_unused", just delete them. If we need to revent, the revert will add them back. -- Steve