Re: [PATCH v5 12/13] module: Move kdb_modules list out of core code

On Thu 2022-02-10 14:05 +0000, Christophe Leroy wrote:

quoted

diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
index 0852a537dad4..f101f5f078f4 100644
--- a/kernel/debug/kdb/kdb_main.c
+++ b/kernel/debug/kdb/kdb_main.c

@@ -59,6 +59,11 @@ EXPORT_SYMBOL(kdb_grepping_flag);
  int kdb_grep_leading;
  int kdb_grep_trailing;

+#ifdef CONFIG_MODULES
+extern struct list_head modules;

Should go in module.h

I disagree. Let's keep it restricted somewhat. The list of loaded/or added
modules is not widely used.

quoted

+struct list_head *kdb_modules = &modules; /* kdb needs the list of modules */

Should be static and should be removed from kernel/debug/kdb/kdb_private.h

Agreed. It is only used in kernel/debug/kdb/kdb_main.c.

quoted

diff --git a/kernel/module/internal.h b/kernel/module/internal.h
index 52d30bf6d6b0..c49b4900b30b 100644
--- a/kernel/module/internal.h
+++ b/kernel/module/internal.h

@@ -225,6 +225,7 @@ static int mod_sysfs_setup(struct module *mod,
  {
      return 0;
  }
+

This should go in previous patch if needed (patch 11 sysfs)

Agreed.


Kind regards,

-- 
Aaron Tomlin