Re: [PATCH 20/22] x86,word-at-a-time: Remove .fixup usage

On Thu, Nov 11, 2021 at 05:50:03PM -0800, Josh Poimboeuf wrote:

Hm, I think there is actually a livepatch problem here.

I suspected as much, because I couldn't find any code dealing with it
when I looked in a hurry.. :/

Some ideas to fix:

c) Update the reliable stacktrace code to mark the stack unreliable if
   it has a function with ".cold" in the name?

Why not simply match func.cold as func in the transition thing? Then
func won't get patched as long as it (or it's .cold part) is in use.
This seems like the natural thing to do.

If there are enough .cold functions, always reporting stacktrace as
unreliable will make progress hard, even though it might be perfectly
safe.

e) Disable .cold optimization?

Yeah, lets not do that. That'll have me lobbying to kill KLP again
because it generates crap code.