Re: [PATCH v2 04/11] sched: Simplify wake_up_*idle*()

On Mon, Oct 18, 2021 at 11:47:32PM -0400, Qian Cai wrote:

Peter, any thoughts? I did confirm that reverting the commit fixed the issue.

On 10/13/2021 10:32 AM, Qian Cai wrote:

quoted

On 9/29/2021 11:17 AM, Peter Zijlstra wrote:

quoted

--- a/kernel/smp.c
+++ b/kernel/smp.c

@@ -1170,14 +1170,14 @@ void wake_up_all_idle_cpus(void)
 {
 	int cpu;
 
-	preempt_disable();
+	cpus_read_lock();
 	for_each_online_cpu(cpu) {
-		if (cpu == smp_processor_id())
+		if (cpu == raw_smp_processor_id())
 			continue;
 
 		wake_up_if_idle(cpu);
 	}
-	preempt_enable();
+	cpus_read_unlock();

Right, so yesterday I thought: YW2KGrvvv/vSA+97@hirez.programming.kicks-ass.net
but today I might have another idea, lemme go prod at this a bit more.