Re: Reference to non-existing DYNAMIC_FTRACE_WITH_ARGS

On Fri, 6 Aug 2021 12:18:36 +0200
Lukas Bulwahn [off-list ref] wrote:

Hi Steven,

Hi Lukas, thanks for the report.

Did you intend to depend on the existing "HAVE_DYNAMIC_FTRACE_WITH_ARGS" here?

Or did you intend to add a new config DYNAMIC_FTRACE_WITH_ARGS
analogously to DYNAMIC_FTRACE_WITH_REGS as defined in
./kernel/trace/Kconfig (see below)?

config DYNAMIC_FTRACE_WITH_REGS
        def_bool y
        depends on DYNAMIC_FTRACE
        depends on HAVE_DYNAMIC_FTRACE_WITH_REGS

I am happy to provide a patch, once I understand what was intended here.

Yeah, that looks to be the missing part. The
HAVE_DYNAMIC_FTRACE_WITH_ARGS is just showing support, but knowing it
is enabled would require DYNAMIC_FTRACE being set (which is user
enabled).

Feel free to send a patch, and mark it for stable.

-- Steve