Thread (4 messages) 4 messages, 2 authors, 2021-08-06

Re: [PATCH] libkmod-module: add support for a patient module removal option

From: Luis Chamberlain <mcgrof@kernel.org>
Date: 2021-08-04 17:59:03
Also in: fstests, linux-block, linux-modules, lkml

On Tue, Aug 03, 2021 at 01:24:17PM -0700, Luis Chamberlain wrote:
+ diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c
<-- snip -->
+		ERR(mod->ctx, "%s refcnt is %ld waiting for it to become 0\n", mod->name, refcnt);
OK after running many tests with this I think we need to just expand
this so that the error message only applies when -v is passed to
modprobe, otherwise we get the print message every time, and using
INFO() doesn't cut it, given the next priority level available to
the library is LOG_INFO (6) and when modprobe -v is passed we set the
log level to LOG_NOTICE (5), so we need a new NOTICE(). I'll send a v2
with that included as a separate patch.

  Luis
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help