Re: [PATCH 04/13] module: use RCU to synchronize find_module

From
Thiago Jung Bauermann <hidden>
Date
2021-01-28 20:52:34
Also in
dri-devel, linux-kbuild, linuxppc-dev, lkml
Reply to
Christoph Hellwig, 2021-01-28
Hi Christoph,

Christoph Hellwig [off-list ref] writes:
quoted hunk ↗ jump to hunk
diff --git a/kernel/module.c b/kernel/module.c
index 981302f616b411..6772fb2680eb3e 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -668,7 +668,6 @@ static struct module *find_module_all(const char *name, size_t len,
 
 struct module *find_module(const char *name)
 {
-	module_assert_mutex();
Does it make sense to replace the assert above with the warn below (untested)?

     RCU_LOCKDEP_WARN(rcu_read_lock_sched_held());
 	return find_module_all(name, strlen(name), false);
 }
-- 
Thiago Jung Bauermann
IBM Linux Technology Center
Thread (12 messages) 12 messages, 3 authors, last reply 2021-01-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help