Re: [PATCH 07/11 v3] livepatch: Trigger WARNING if livepatch function fails due to recursion
From: Miroslav Benes <mbenes@suse.cz>
Date: 2020-11-06 10:07:28
Also in:
lkml
From: Miroslav Benes <mbenes@suse.cz>
Date: 2020-11-06 10:07:28
Also in:
lkml
On Thu, 5 Nov 2020, Steven Rostedt wrote:
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org> If for some reason a function is called that triggers the recursion detection of live patching, trigger a warning. By not executing the live patch code, it is possible that the old unpatched function will be called placing the system into an unknown state. Link: https://lore.kernel.org/r/20201029145709.GD16774@alley (local) Cc: Josh Poimboeuf <redacted> Cc: Jiri Kosina <jikos@kernel.org> Cc: Joe Lawrence <joe.lawrence@redhat.com> Cc: live-patching@vger.kernel.org Suggested-by: Miroslav Benes <mbenes@suse.cz> Reviewed-by: Petr Mladek <pmladek@suse.com> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Miroslav Benes <mbenes@suse.cz>
--- Changes since v2: - Blame Miroslav instead of Petr ;-)
Thanks. Fortunately, if printk is broken in WARN_ON_ONCE(), I can always blame Petr again :) M