Re: [PATCH v4 00/10] Function Granular KASLR

On Fri, 2020-08-07 at 10:20 -0700, Kees Cook wrote:

On Fri, Aug 07, 2020 at 09:38:11AM -0700, Kristen Carlson Accardi
wrote:

quoted

Thanks for testing. Yes, Josh and I have been discussing the
orc_unwind
issues. I've root caused one issue already, in that objtool places
an
orc_unwind_ip address just outside the section, so my algorithm
fails
to relocate this address. There are other issues as well that I
still
haven't root caused. I'll be addressing this in v5 and plan to have
something that passes livepatch testing with that version.

FWIW, I'm okay with seeing fgkaslr be developed progressively.
Getting
it working with !livepatching would be fine as a first step. There's
value in getting the general behavior landed, and then continuing to
improve it.

In this case, part of the issue with livepatching appears to be a more
general issue with objtool and how it creates the orc unwind entries
when you have >64K sections. So livepatching is a good test case for
making sure that the orc tables are actually correct. However, the
other issue with livepatching (the duplicate symbols), might be worth
deferring if the solution is complex - I will keep that in mind as I
look at it more closely.