Re: [PATCH 2/7] modules: mark find_symbol static

On 7/29/20 12:24 PM, Greg Kroah-Hartman wrote:

On Wed, Jul 29, 2020 at 06:13:18PM +0200, Jessica Yu wrote:

quoted

+++ Christoph Hellwig [29/07/20 08:27 +0200]:

quoted

find_symbol is only used in module.c.

Signed-off-by: Christoph Hellwig <hch@lst.de>

CCing the livepatching ML, as this may or may not impact its users.

AFAIK, the out-of-tree kpatch module had used find_symbol() in the
past, I am not sure what its current status is. I suspect all of its
functionality has been migrated to upstream livepatch already.

We still have symbol_get(), which is what I thought they were using.

The deprecated (though still in the repo) kpatch.ko still references find_symbol(), but that module is no longer officially supported by the project.

Jessica is correct that the functionality has been migrated upstream.

I don't see any references to symbol_get() either, so we're good on that front, too.

Thanks,

-- Joe