Re: [PATCH -next] livepatch: Make klp_apply_object_relocs static
From: Kamalesh Babulal <hidden>
Date: 2020-05-08 14:35:36
Also in:
lkml
On 5/8/20 5:36 PM, Samuel Zou wrote:
Fix the following sparse warning: kernel/livepatch/core.c:748:5: warning: symbol 'klp_apply_object_relocs' was not declared. Should it be static? Reported-by: Hulk Robot <redacted> Signed-off-by: Samuel Zou <redacted>
LGTM, klp_apply_object_relocs() has only one call site within core.c Reviewed-by: Kamalesh Babulal <redacted>
quoted hunk ↗ jump to hunk
--- kernel/livepatch/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index 96d2da1..f76fdb9 100644 --- a/kernel/livepatch/core.c +++ b/kernel/livepatch/core.c@@ -745,7 +745,8 @@ static int klp_init_func(struct klp_object *obj, struct klp_func *func) func->old_sympos ? func->old_sympos : 1); } -int klp_apply_object_relocs(struct klp_patch *patch, struct klp_object *obj) +static int klp_apply_object_relocs(struct klp_patch *patch, + struct klp_object *obj) { int i, ret; struct klp_modinfo *info = patch->mod->klp_info;