Re: [PATCH v4 06/11] s390/module: Use s390_kernel_write() for late relocations
From: Gerald Schaefer <hidden>
Date: 2020-05-07 12:28:01
Also in:
linux-s390, lkml
On Thu, 7 May 2020 12:00:13 +0200 (CEST) Jiri Kosina [off-list ref] wrote:
On Wed, 29 Apr 2020, Josh Poimboeuf wrote:quoted
From: Peter Zijlstra <peterz@infradead.org> Because of late module patching, a livepatch module needs to be able to apply some of its relocations well after it has been loaded. Instead of playing games with module_{dis,en}able_ro(), use existing text poking mechanisms to apply relocations after module loading. So far only x86, s390 and Power have HAVE_LIVEPATCH but only the first two also have STRICT_MODULE_RWX. This will allow removal of the last module_disable_ro() usage in livepatch. The ultimate goal is to completely disallow making executable mappings writable. [ jpoimboe: Split up patches. Use mod state to determine whether memcpy() can be used. Test and add fixes. ] Cc: linux-s390@vger.kernel.org Cc: Heiko Carstens <redacted> Cc: Gerald Schaefer <redacted> Cc: Christian Borntraeger <redacted> Suggested-by: Josh Poimboeuf <redacted> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by: Josh Poimboeuf <redacted> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Joe Lawrence <joe.lawrence@redhat.com> Acked-by: Miroslav Benes <mbenes@suse.cz>Could we please get an Ack / Reviewed-by: for this patch from s390 folks? Thanks,
Looks pretty straightforward, and using s390_kernel_write() is OK, so Acked-by: Gerald Schaefer <redacted> # s390