Thread (8 messages) 8 messages, 3 authors, 2019-07-24

Re: [PATCH v4] selftests/livepatch: add test skip handling

From: shuah <shuah@kernel.org>
Date: 2019-07-24 20:19:52
Also in: linux-kselftest

On 7/24/19 2:05 PM, Joe Lawrence wrote:
Add a skip() message function that stops the test, logs an explanation,
and sets the "skip" return code (4).

Before loading a livepatch self-test kernel module, first verify that
we've built and installed it by running a 'modprobe --dry-run'.  This
should catch a few environment issues, including !CONFIG_LIVEPATCH and
!CONFIG_TEST_LIVEPATCH.  In these cases, exit gracefully with the new
skip() function.

Reported-by: Jiri Benc <redacted>
Suggested-by: Shuah Khan <shuah@kernel.org>
Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
---

v4: s/unable load/unable to load/ in user visible skip message. [shuah]
Thanks. Applied to linux-ksefktest fixes for 5.3-rc2 with Petr's Ack

thanks,
-- Shuah
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help