powerpc/crash: update fdt on cpu hotplug remove

Started by Shivang Upadhyay on Nov 3, 2026 · 2 messages from 2 authors · Last reply Nov 3, 2026

Subsystems (2)

Maintainers (2)

WARM2d

open the first message on its own page

Message details and related content
Currently fdt for crash kernel is not updated on cpu hotplug remove,
which can lead to the following XIVE warnings on the crash kernel
bringup.

[    0.630795][    T1] xive: H_INT_GET_QUEUE_INFO cpu=16 prio=6 failed -55
[    0.630912][    T1] xive: Error -55 getting queue info CPU 16 prio 6
[    0.680899][    T1] xive: H_INT_GET_QUEUE_INFO cpu=17 prio=6 failed -55
[    0.681000][    T1] xive: Error -55 getting queue info CPU 17 prio 6

Fixing this by updating crash fdt on cpu hotplug remove path also.

Reported-by: Anushree Mathur <redacted>
Suggested-by: Sourabh Jain <redacted>
Signed-off-by: Shivang Upadhyay <redacted>
---
 arch/powerpc/kexec/crash.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/kexec/crash.c b/arch/powerpc/kexec/crash.c
index 775895f31037..0ef10e39ae49 100644
--- a/arch/powerpc/kexec/crash.c
+++ b/arch/powerpc/kexec/crash.c
@@ -639,8 +639,6 @@ void arch_crash_handle_hotplug_event(struct kimage *image, void *arg)
 
 	switch (image->hp_action) {
 	case KEXEC_CRASH_HP_REMOVE_CPU:
-		return;
-
 	case KEXEC_CRASH_HP_ADD_CPU:
 		update_crash_fdt(image);
 		break;
-- 
2.54.0

Message details and related content

在 2026/11/3 16:53, Shivang Upadhyay 写道:
quoted hunk
Currently fdt for crash kernel is not updated on cpu hotplug remove,
which can lead to the following XIVE warnings on the crash kernel
bringup.

[    0.630795][    T1] xive: H_INT_GET_QUEUE_INFO cpu=16 prio=6 failed -55
[    0.630912][    T1] xive: Error -55 getting queue info CPU 16 prio 6
[    0.680899][    T1] xive: H_INT_GET_QUEUE_INFO cpu=17 prio=6 failed -55
[    0.681000][    T1] xive: Error -55 getting queue info CPU 17 prio 6

Fixing this by updating crash fdt on cpu hotplug remove path also.

Reported-by: Anushree Mathur <redacted>
Suggested-by: Sourabh Jain <redacted>
Signed-off-by: Shivang Upadhyay <redacted>
---
 arch/powerpc/kexec/crash.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/kexec/crash.c b/arch/powerpc/kexec/crash.c
index 775895f31037..0ef10e39ae49 100644
--- a/arch/powerpc/kexec/crash.c
+++ b/arch/powerpc/kexec/crash.c
@@ -639,8 +639,6 @@ void arch_crash_handle_hotplug_event(struct kimage *image, void *arg)
 
 	switch (image->hp_action) {
 	case KEXEC_CRASH_HP_REMOVE_CPU:
-		return;
-
LGTM
Reviewed-by: Jinjie Ruan <redacted>
 	case KEXEC_CRASH_HP_ADD_CPU:
 		update_crash_fdt(image);
 		break;
-- 
Best regards,
Jinjie

Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help