Declare the seq_operations and the size of the iterator and let procfs
open and free the seq_file. ->proc_open() only initializes the iterator
now.
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
---
kernel/kallsyms.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c
index aec2f06858af..2d309fcee730 100644
--- a/kernel/kallsyms.c
+++ b/kernel/kallsyms.c
@@ -888,10 +888,9 @@ static int kallsyms_open(struct inode *inode, struct file *file)
* s_start from where we left off, so we avoid doing
* using get_symbol_offset for every symbol.
*/
- struct kallsym_iter *iter;
- iter = __seq_open_private(file, &kallsyms_op, sizeof(*iter));
- if (!iter)
- return -ENOMEM;
+ struct seq_file *m = file->private_data;
+ struct kallsym_iter *iter = m->private;
+
reset_iter(iter, 0);
/*
@@ -923,10 +922,9 @@ const char *kdb_walk_kallsyms(loff_t *pos)
#endif /* CONFIG_KGDB_KDB */
static const struct proc_ops kallsyms_proc_ops = {
+ .proc_seq_ops = &kallsyms_op,
+ .proc_state_size = sizeof(struct kallsym_iter),
.proc_open = kallsyms_open,
- .proc_read = seq_read,
- .proc_lseek = seq_lseek,
- .proc_release = seq_release_private,
};
static int __init kallsyms_init(void)
--
2.53.0