[PATCH 7/7] asm-generic: Remove the unused non-atomic local64_t functions
flat view
DORMANTno replies
From: Jerome Marchand <hidden>
Date: 2026-10-26 11:19:20
Also in:
linux-alpha, linux-arch, linux-mips, lkml, loongarch
Subsystem:
generic include/asm header files, the rest · Maintainers:
Arnd Bergmann, Linus Torvalds
While working on a fix for a tracing soft lockup, it came to my attention that __local_dec() was broken on ppc64 and other arches (it actually increment the value). My first instinct was to fix it but the fact that this function was utterly broken for so long, decades for some arches makes me thing that those functions have not been used for a long time, if ever. The local64_t non-atomic functions aren't used either, so remove them too. Signed-off-by: Jerome Marchand <redacted> --- include/asm-generic/local64.h | 14 -------------- 1 file changed, 14 deletions(-)
diff --git a/include/asm-generic/local64.h b/include/asm-generic/local64.h
index 14963a7a62538..b30ae05f42b95 100644
--- a/include/asm-generic/local64.h
+++ b/include/asm-generic/local64.h@@ -56,13 +56,6 @@ static inline bool local64_try_cmpxchg(local64_t *l, s64 *old, s64 new) #define local64_add_unless(l, _a, u) local_add_unless((&(l)->a), (_a), (u)) #define local64_inc_not_zero(l) local_inc_not_zero(&(l)->a) -/* Non-atomic variants, ie. preemption disabled and won't be touched - * in interrupt, etc. Some archs can optimize this case well. */ -#define __local64_inc(l) local64_set((l), local64_read(l) + 1) -#define __local64_dec(l) local64_set((l), local64_read(l) - 1) -#define __local64_add(i,l) local64_set((l), local64_read(l) + (i)) -#define __local64_sub(i,l) local64_set((l), local64_read(l) - (i)) - #else /* BITS_PER_LONG != 64 */ #include <linux/atomic.h>
@@ -95,13 +88,6 @@ typedef struct { #define local64_add_unless(l, _a, u) atomic64_add_unless((&(l)->a), (_a), (u)) #define local64_inc_not_zero(l) atomic64_inc_not_zero(&(l)->a) -/* Non-atomic variants, ie. preemption disabled and won't be touched - * in interrupt, etc. Some archs can optimize this case well. */ -#define __local64_inc(l) local64_set((l), local64_read(l) + 1) -#define __local64_dec(l) local64_set((l), local64_read(l) - 1) -#define __local64_add(i,l) local64_set((l), local64_read(l) + (i)) -#define __local64_sub(i,l) local64_set((l), local64_read(l) - (i)) - #endif /* BITS_PER_LONG != 64 */ #endif /* _ASM_GENERIC_LOCAL64_H */
--
2.56.0