Thread (7 messages) 7 messages, 6 authors, 1h ago

Re: [PATCH] powerpc/irq: Fix build with CONFIG_PROC_FS=n

flat view

From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Date: 2026-10-24 00:15:45
Also in: lkml

Sasha Levin [off-list ref] writes:
Commit fbb22ceaaf8f ("powerpc/irq: Make irqstats array based") made
arch_show_interrupts() call irq_proc_emit_counts(). That function lives
in kernel/irq/proc.c, which is only built with CONFIG_PROC_FS, so
kernels without procfs no longer link:

  powerpc64-linux-ld: arch/powerpc/kernel/irq.o: in function `arch_show_interrupts':
  arch/powerpc/kernel/irq.c:134:(.text+0x4b8c): undefined reference to `irq_proc_emit_counts'

arch_show_interrupts() is only called from irq_seq_show(), which is in
kernel/irq/proc.c as well, so build it only with CONFIG_PROC_FS, as x86
already does.

Fixes: fbb22ceaaf8f ("powerpc/irq: Make irqstats array based")
Reported-by: kernel test robot <redacted>
Closes: https://lore.kernel.org/oe-kbuild-all/202609271531.8kf2NTjK-lkp@intel.com/ (local)
Looks like it still slipped through.
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
Change looks good to me. Thanks Sasha for fixing it. 

-ritesh

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help