[PATCH 09/11] ASoC: renesas: rz-ssi: Explain component open return value handling
flat view
HOTtoday
From: <hidden>
Date: 2026-10-16 04:12:03
Also in:
asahi, imx, linux-renesas-soc, linux-rockchip, linux-sound, lkml
Subsystem:
renesas rz audio (asoc) driver, sound, sound - soc layer / dynamic audio power management (asoc), the rest · Maintainers:
Biju Das, Lad Prabhakar, Jaroslav Kysela, Takashi Iwai, Liam Girdwood, Mark Brown, Linus Torvalds
From: bui duc phuc <redacted> Add a comment explaining why .open() must return 0 on success to ensure the component is correctly marked as opened and prevent future changes from reintroducing the issue. Signed-off-by: bui duc phuc <redacted> --- sound/soc/renesas/rz-ssi.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c
index 2e297f721bb6..9f36fe2c16d2 100644
--- a/sound/soc/renesas/rz-ssi.c
+++ b/sound/soc/renesas/rz-ssi.c@@ -946,6 +946,11 @@ static int rz_ssi_pcm_open_pio(struct snd_soc_component *component, if (ret < 0) return ret; + /* + * ASoC only marks the component as opened when .open() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure the component is correctly marked as opened. + */ return 0; }
--
2.43.0