Re: [PATCH v3 29/40] mm: drop some redundant checks around hugetlb VMAs
From: "David Hildenbrand (Arm)" <david@kernel.org>
Date: 2026-10-02 06:55:25
Also in:
bpf, fuse-devel, kvm, kvm-riscv, kvmarm, linux-arch, linux-doc, linux-fbdev, linux-fsdevel, linux-mm, linux-perf-users, linux-rdma, linux-s390, linux-scsi, linux-sound, linux-trace-kernel, linux-usb, lkml, selinux, sparclinux
On 9/17/26 18:22, Lorenzo Stoakes (ARM) wrote:
Adjust code which inadvertently perform redundant checks on hugetlb VMAs and clean them up: * hugetlb VMAs have VMA_DONTEXPAND_BIT set so a VMA_SPECIAL_FLAGS check suffices. (migrate_vma_setup() regains an explicit hugetlb test later in the series, once VMA_SPECIAL_FLAGS is removed.) * hugetlb VMAs unconditionally set vma->vm_ops, so they are never anonymous. * hugetlb VMAs do not set VMA_PFNMAP_BIT so checking for this is redundant. While we're here also drop a VM_BUG_ON() which the simplified check above makes unreachable, and use the new VMA flag API. No functional change intended. Acked-by: Marc Zyngier <maz@kernel.org> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org> ---
Acked-by: David Hildenbrand (Arm) <david@kernel.org> -- Cheers, David