Thread (2 messages) flat view 2 messages, 2 authors, 2d ago

Re: [PATCH v2] docs: powerpc: vas-api: Fix the structure name and the ioctl number in the example

From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Date: 2026-09-07 03:10:17
Also in: linux-doc

Karl Mehltretter [off-list ref] writes:
struct vas_setup_attr does not exist; the name is struct
vas_tx_win_open_attr. The example also defines VAS_TX_WIN_OPEN with the
request number 1, while arch/powerpc/include/uapi/asm/vas-api.h has used
0x20 since the ioctl was added.

Use struct vas_tx_win_open_attr and 0x20.

Fixes: c12e38b1d52e ("Documentation/powerpc: VAS API")
Suggested-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <redacted>
---
v2: also fix the ioctl request number in the example (Ritesh)
v1: https://lore.kernel.org/r/20260905104313.43620-1-kmehltretter@gmail.com/ (local)

 Documentation/arch/powerpc/vas-api.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks for fixing the ioctl number too and sending a v2.
LGTM. Please feel free to add:

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help