Re: [PATCH v3 net-next 8/8] net: dsa: netc: add PTP one-step timestamping support

From
Jakub Kicinski <kuba@kernel.org>
Date
2026-09-05 00:52:36
Also in
imx, linux-arm-kernel, lkml, netdev
Reply to
unknown sender, 2026-08-31
On Mon, 31 Aug 2026 16:23:35 +0800 wei.fang@oss.nxp.com wrote:
The NETC switch supports one-step TX timestamping for PTP Sync frames.
When transmitting a Sync frame, the driver reads the current PTP time
and writes it into the frame's originTimestamp field, and inserts a
To_Port subtype 1 tag carrying the low 30 bits of that same PTP time.
As the frame leaves the wire, the MAC captures the SFD transmit time
and derives the residence time from the timestamp in the tag. It then
reads the correction field at the offset given by
PM_SINGLE_STEP[OFFSET], adds the residence time to it, and writes the
result back.
Please spend more time on this code, especially this patch.
This really looks like clumsy slop, some DSA expert will
have to review it before it gets merged.
Thread (19 messages) 19 messages, 5 authors, last reply 2026-09-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help