Re: [PATCH 1/2] watchdog: wdrtas: Fix kernel-doc parameter name for wdrtas_reboot()
From: Guenter Roeck <linux@roeck-us.net>
Date: 2026-08-06 21:32:28
Also in:
linux-watchdog, lkml
On Thu, Jul 30, 2026 at 06:06:16AM +0000, Babanpreet Singh wrote:
scripts/kernel-doc -none reports: Warning: drivers/watchdog/wdrtas.c:460 function parameter 'this' not described in 'wdrtas_reboot' Warning: drivers/watchdog/wdrtas.c:460 Excess function parameter 'nb' description in 'wdrtas_reboot' wdrtas_reboot() names its notifier block argument 'this', but the kernel-doc comment documents a parameter named 'nb'. Update the kernel-doc comment to document the 'this' parameter. Assisted-by: Claude:claude-opus-5 Signed-off-by: Babanpreet Singh <redacted>
This is a 20+ years old driver which doesn't use the watchdog subsystem. I am not going to apply any patches to it unless the author shows that it is a real problem observed on real hardware, and then I am likely going to ask for a conversion to the watchdog subsystem unlesss it is a critical aproblem and not just something AI came up with as a possible issue. Guenter
quoted hunk ↗ jump to hunk
--- drivers/watchdog/wdrtas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/watchdog/wdrtas.c b/drivers/watchdog/wdrtas.c index d4fe0bc822116..6c25171de224e 100644 --- a/drivers/watchdog/wdrtas.c +++ b/drivers/watchdog/wdrtas.c@@ -448,7 +448,7 @@ static int wdrtas_temp_close(struct inode *inode, struct file *file) /** * wdrtas_reboot - reboot notifier function - * @nb: notifier block structure + * @this: notifier block structure * @code: reboot code * @ptr: unused *