Thread (14 messages) flat view 14 messages, 3 authors, 5d ago

Re: [PATCH 1/4] powerpc/pseries: Limit PVR list to 16 entries for CAS negotiation

From: Nikhil Kumar Singh <hidden>
Date: 2026-08-03 03:22:36


On 29/07/26 20:24, Mahesh Salgaonkar wrote:
+	if ((ARRAY_SIZE(ibm_architecture_vec_template.pvrs) > 16) &&
+	    (PVR_VER(mfspr(SPRN_PVR)) <= PVR_POWER11))
+		start_index = ARRAY_SIZE(ibm_architecture_vec_template.pvrs) - 16;


Hi Mahesh,

The literal 16 appears twice. Please define a named macro,
e.g.: #define CAS_MAX_PVR_ENTRIES 16

Thanks,
~ Nikhil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help