Thread (14 messages) flat view 14 messages, 4 authors, 16d ago

Re: [PATCH] soc: fsl: qe: properly scan GPIO nodes at startup

From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
Date: 2026-07-30 12:04:38
Also in: linux-arm-kernel, lkml

Hi Krzysztof,

Le 30/07/2026 à 13:15, Krzysztof Kozlowski a écrit :
On 30/07/2026 10:14, Christophe Leroy (CS GROUP) wrote:
quoted
On Wed, 29 Jul 2026 16:10:36 +0200, Christophe Leroy (CS GROUP) wrote:
quoted
Before commit 156460811def ("soc: fsl: qe: Change GPIO driver to a
proper platform driver") qe_add_gpiochips() was walking the device
tree to find all nodes with compatible "fsl,mpc8323-qe-pario-bank".

After that commit the discovery is handled by the platform core,
therefore it is necessary to call of_platform_default_populate() on
the par_io node.

[...]
Applied, thanks!

[1/1] soc: fsl: qe: properly scan GPIO nodes at startup
       commit: cf91e5909e620b77164b53c9b316a5c1f11f9ea7
You left very little time to respond to this - one day - and introduced
undocumented disallowed ABI. Please drop the patch. I will be objecting
to the entire pull request.
Yes sorry for that, I thought the reviewed-by: GPIO maintainer + 
discussion with Herve was enough.

I'll fix it up before sending pull request. Thanks for reviewing and 
providing feedback.

Christophe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help