Thread (4 messages) flat view 4 messages, 2 authors, 8d ago
COOLING8d

Revision v2 of 2 in this series.

Revisions (2)
  1. v1 [diff vs current]
  2. v2 current

[PATCH v2 0/2] powerpc/sstep: Fix compilation on 32-bit PowerPC

From: Link Mauve <hidden>
Date: 2026-07-30 06:50:19
Also in: lkml

Two local variables were only set but never read on 32-bit PowerPC,
which causes an error during compilation with W=1.

This series first makes the 64-bit guards consistent by converting all
uses of __powerpc64__ to use CONFIG_PPC64 instead, and then guard the
two variables rc and suffix behind CONFIG_PPC64 checks.

Link Mauve (2):
  powerpc/sstep: Consistently use one define to check arch bit width
  powerpc/sstep: Don’t define variables we won’t be using

 arch/powerpc/lib/sstep.c | 111 ++++++++++++++++++++-------------------
 1 file changed, 58 insertions(+), 53 deletions(-)

Changes since v1:
- Link to v1:
  https://lore.kernel.org/linuxppc-dev/amrpdv0g__ELifId@desktop/T/ (local)
- Switch from __powerpc64__ to CONFIG_PPC64, as it is the preferred
  check.
- Document that the build error was only occurring with W=1.
- Declare both variables on the same line.

base-commit: 78bc8af4affb9a732504eb22eeac7d1e50883853
-- 
2.55.0

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help