Thread (2 messages) 2 messages, 2 authors, 3d ago

Re: [PATCH] USB: phy: fsl-usb: fix missing static keywords

From: Manuel Ebner <hidden>
Date: 2026-07-18 11:30:20
Also in: linux-next, linux-usb, lkml, stable

On Fri, 2026-07-17 at 17:49 +0200, Johan Hovold wrote:
A recent change enabling compile testing of a Freescale dual-role
controller indirectly enabled a USB PHY driver to be built. That driver
in turn is missing a bunch of static keywords which results in warnings
like:

drivers/usb/phy/phy-fsl-usb.c:105:5: error: no previous prototype for 'write_ulpi' [-
Werror=missing-prototypes]
  105 | int write_ulpi(u8 addr, u8 data)
        |     ^~~~~~~~~~

which consequently breaks -Werror builds.

Add the missing static keywords.

Fixes: 0807c500a1a6 ("USB: add Freescale USB OTG Transceiver driver")
Cc: stable@vger.kernel.org	# 3.0
Add linux-next@vger.kernel.org
Reported-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/4f9f5ff9-8eaa-4bd5-9331-37119f78e13f@sirena.org.uk (local)
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Manuel Ebner <redacted>

Thanks
 Manuel
---
 drivers/usb/phy/phy-fsl-usb.c | 52 +++++++++++++++++------------------
 drivers/usb/phy/phy-fsl-usb.h |  6 ++--
 2 files changed, 29 insertions(+), 29 deletions(-)

[...]
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help