Thread (3 messages) 3 messages, 1 author, 4d ago
COOLING4d

[PATCH 0/2] ASoC: fsl: fix m2m_init error path cleanup in fsl_asrc and fsl_easrc

From: <hidden>
Date: 2026-07-15 02:43:31
Also in: linux-sound, lkml

From: Shengjiu Wang <redacted>

Both fsl_asrc_probe() and fsl_easrc_probe() call fsl_asrc_m2m_init()
near the end of their probe functions. On failure, the original code
did a bare return ret, bypassing the existing error labels that call
pm_runtime_disable(). This leaves runtime PM enabled and the device
in an inconsistent state after a failed probe.

Fix both drivers by replacing the bare return with a goto to the
appropriate cleanup label (err_pm_get_sync for fsl_asrc and
err_pm_disable for fsl_easrc), ensuring pm_runtime_disable() is
always called on the probe error path.

Shengjiu Wang (2):
  ASoC: fsl_asrc: fix m2m_init error path to use goto instead of bare
    return
  ASoC: fsl_easrc: fix m2m_init error path to use goto instead of bare
    return

 sound/soc/fsl/fsl_asrc.c  | 2 +-
 sound/soc/fsl/fsl_easrc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--
2.34.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help