Re: [PATCH v7 06/10] ACPI: APEI: GHES: move CXL CPER helpers

On 14/07/2026 03:45, Alison Schofield wrote:

On Wed, Jul 08, 2026 at 02:59:05PM +0100, Ahmed Tiba wrote:

quoted

Move the CXL CPER handling paths out of ghes.c and into ghes_cper.c so the
helpers can be reused. The code is moved as-is, with the public
prototypes updated so GHES keeps calling into the new translation unit.

While moving this code, also add CXL CPER section length checks and use
spinlock_irqsave() in CXL register/unregister paths for locking
consistency.

NAK on moving and changing in the same patch, and esp in a patch
whose subject only says MOVE.

Hi Alison,

I understand the concern.

I kept those changes in 06/10 because they address pre-existing issues
reported specifically against this patch by Sashiko, and I wanted to 
avoid carrying known defects forward in the series. I did this following 
Boris' feedback to address review-reported issues in-series rather than 
carry them forward unchanged.

I can also add a dedicated "Sashiko findings addressed" section and 
update the commit description to state clearly that this patch is not 
pure move.

Please advise your preferred way to address Sashiko findings per patch 
in this series.

Thanks,
Ahmed