Re: [PATCH v7 02/22] dma-pool: fix page leak in atomic_pool_expand() cleanup
From: Jason Gunthorpe <jgg@ziepe.ca>
Date: 2026-07-13 17:54:46
Also in:
linux-arm-kernel, linux-coco, linux-iommu, linux-s390, lkml
On Wed, Jul 01, 2026 at 11:19:06AM +0530, Aneesh Kumar K.V (Arm) wrote:
quoted hunk ↗ jump to hunk
@@ -115,8 +116,10 @@ static int atomic_pool_expand(struct gen_pool *pool, size_t pool_size, */ ret = set_memory_decrypted((unsigned long)page_to_virt(page), 1 << order); - if (ret) + if (ret) { + leak_pages = true; goto remove_mapping; + }
Truely these _set_memory_decrypted() things are an insane API. So a if it fails to decrypt it can be in any messy state?
quoted hunk ↗ jump to hunk
@@ -130,14 +133,15 @@ static int atomic_pool_expand(struct gen_pool *pool, size_t pool_size, 1 << order); if (WARN_ON_ONCE(ret)) { /* Decrypt succeeded but encrypt failed, purposely leak */ - goto out; + leak_pages = true;
At least this one makes some sense.. Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Jason