Thread (19 messages) 19 messages, 3 authors, 13d ago

Re: [PATCH v2 1/9] time: Respect COMPAT_32BIT_TIME for old time type functions

From: Thomas Weißschuh <hidden>
Date: 2026-07-01 08:40:39
Also in: linux-api, linux-arm-kernel, linux-mips, lkml, sparclinux

On Tue, Jun 30, 2026 at 03:00:37PM +0200, Arnd Bergmann wrote:
On Tue, Jun 30, 2026, at 09:38, Thomas Weißschuh wrote:
quoted
The "old" time types use 32-bit seconds which are not y2038-safe.
Respect COMPAT_32BIT_TIME for functions using those types.
time(), stime() and gettimeofday() are disabled completely.
Looks good, yes
Sashiko found an issue [0], which I think is valid. I'll change that for v3.
quoted
settimeofday() is kept as it is required to do the initial timewarping
after boot. However the 'tv' argument will be rejected.
Not sure about this part, did we already discuss this last time?
This is my interpretation of [1].
I can see how keeping the timewarping functionality is the easy way
out, but completely disabling the settimeofday syscall the same
way we do on new architectures seems so much more consistent.
Shouldn't we then do this completely? Irrespective of COMPAT_32BIT_TIME?
And then remove all of the timewarping and kernel timezone bits.

It would be nice however if this series, and my other ones blocked behind it,
are not blocked on that larger rework.

(...)

[0] https://sashiko.dev/#/patchset/20260630-vdso-compat_32bit_time-v2-0-520d194640dd%40linutronix.de?part=1
[1] https://lore.kernel.org/all/e9487ebe-3730-438a-9c23-e45f75986ecc@app.fastmail.com/ (local)


Thomas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help