Re: [PATCH v4 2/2] tracing: Remove trace_printk.h from kernel.h
From: Steven Rostedt <rostedt@kernel.org>
Date: 2026-06-26 08:51:29
Also in:
dri-devel, intel-gfx, kvm, linux-arm-kernel, linux-doc, linux-ext4, linux-kbuild, linux-nfs, linux-rdma, linux-trace-kernel, linux-usb, lkml
On Thu, 25 Jun 2026 16:41:58 -0700 Nathan Chancellor [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The following diff resolves it for me, should I send it as a separate patch or do you want to just fold it in with a note?diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h index 621566345406..2301a701ffbb 100644 --- a/include/linux/lockdep.h +++ b/include/linux/lockdep.h@@ -10,6 +10,7 @@ #ifndef __LINUX_LOCKDEP_H #define __LINUX_LOCKDEP_H +#include <linux/instruction_pointer.h>
Ah, so the reason for this breakage is because lockdep was relying on instruction_pointer.h, that just happened to be included in kernel.h via trace_printk.h. This is a separate issue, so it should be a separate patch. I'll add it as patch 1 of this series. Can you send me the config you used. This didn't trigger in my tests. Thanks, -- Steve
#include <linux/lockdep_types.h> #include <linux/smp.h> #include <asm/percpu.h>