Re: [PATCH 2/2] of/fdt: make early_init_dt_scan_chosen() return void

Hello,

On Tue, Jun 2, 2026 at 7:03 AM Rob Herring [off-list ref] wrote:

On Mon, May 11, 2026 at 02:13:53AM +0900, Sang-Heon Jeon wrote:

quoted

Since commit 064e32dc5b03 ("of: fdt: Honor CONFIG_CMDLINE* even
without /chosen node, take 2"), early_init_dt_scan_chosen() always
returns 0, so the return value checks at its callers have become
dead code.

Drop the return value, change the function to return void, and
update its declaration and callers accordingly. No functional
change.

Signed-off-by: Sang-Heon Jeon <redacted>
---
dt-test result

[    0.684136] ### dt-test ### start of unittest - you will see error messages
[    0.685849] ### dt-test ### EXPECT \ : Duplicate name in testcase-data, renamed to "duplicate-name#1"
[    0.685870] Duplicate name in testcase-data, renamed to "duplicate-name#1"
[    0.689496] ### dt-test ### EXPECT / : Duplicate name in testcase-data, renamed to "duplicate-name#1"

...

[    1.693384] ### dt-test ### EXPECT / : OF: resolver: overlay phandle fixup failed: -22
[    1.693386] ### dt-test ### EXPECT / : OF: resolver: node label 'this_label_does_not_exist' not found in live devicetree symbols table
[    1.694968] ### dt-test ### end of unittest - 405 passed, 0 failed
---
 drivers/of/fdt.c       | 10 ++--------
 include/linux/of_fdt.h |  2 +-
 2 files changed, 3 insertions(+), 9 deletions(-)

Looks like this is dependent on patch 1, so I'm assuming the PPC folks
will take the series.

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Thanks for reviewing, Rob :)

The merge window is now open. PPC folks, could you take a look and
pick this series up for 7.2?

Best Regards,
Sang-Heon Jeon