Re: [PATCHv3 01/15] dmaengine: fsldma: kill tasklet before removing channel
From: Frank Li <hidden>
Date: 2026-06-10 01:36:26
Also in:
dmaengine, lkml, llvm
On Tue, Jun 09, 2026 at 03:19:12PM -0700, Rosen Penev wrote:
Add tasklet_kill() in fsl_dma_chan_remove() to prevent a race where the tasklet, scheduled by the IRQ handler, runs after the channel has been freed.
Nit: please wrap at 75 char Add tasklet_kill() in fsl_dma_chan_remove() to prevent a race where the tasklet is scheduled by the IRQ handler and runs after the channel has been freed.
Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev <redacted> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
quoted hunk ↗ jump to hunk
drivers/dma/fsldma.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 22d62d958abd..0e2f84862261 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c@@ -1205,6 +1205,7 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev, static void fsl_dma_chan_remove(struct fsldma_chan *chan) { + tasklet_kill(&chan->tasklet); irq_dispose_mapping(chan->irq); list_del(&chan->common.device_node); iounmap(chan->regs); --2.54.0