Re: [PATCH 07/10] dmaengine: fsldma: convert channel ioremap to devm_of_iomap
From: Frank Li <hidden>
Date: 2026-06-05 22:50:10
Also in:
dmaengine, lkml, llvm
On Fri, Jun 05, 2026 at 03:01:31PM -0700, Rosen Penev wrote:
Replace of_iomap with devm_of_iomap for per-channel register
all funcation need (), devm_of_iomap(), please check subject and other patches
mappings. This eliminates the iounmap calls in both the probe
Needn't "This", just, Eeliminate the eliminates()
error path and fsl_dma_chan_remove, and simplifies the error handling by returning directly on failure.
commit message allow 75 chars each line, can you wrap it at 75 to reduce line number.
quoted hunk ↗ jump to hunk
Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev <redacted> --- drivers/dma/fsldma.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-)diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index ee6e595c2972..0d73ce3dbfe6 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c@@ -1108,7 +1108,6 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev, { struct fsldma_chan *chan; struct resource res; - int err; /* alloc channel */ chan = devm_kzalloc(fdev->dev, sizeof(*chan), GFP_KERNEL);@@ -1116,17 +1115,16 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev, return -ENOMEM; /* ioremap registers for use */ - chan->regs = of_iomap(node, 0); - if (!chan->regs) { + chan->regs = devm_of_iomap(fdev->dev, node, 0, NULL); + if (IS_ERR(chan->regs)) { dev_err(fdev->dev, "unable to ioremap registers\n"); - err = -ENOMEM; - goto out_free_chan; + return PTR_ERR(chan->regs);
dev_err follow return use return dev_err_probe() Frank
quoted hunk ↗ jump to hunk
} - err = of_address_to_resource(node, 0, &res); + int err = of_address_to_resource(node, 0, &res); if (err) { dev_err(fdev->dev, "unable to find 'reg' property\n"); - goto out_iounmap_regs; + return err; } chan->feature = feature;@@ -1145,8 +1143,7 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev, ((res.start - 0x200) & 0xfff) >> 7; if (chan->id >= FSL_DMA_MAX_CHANS_PER_DEVICE) { dev_err(fdev->dev, "too many channels for device\n"); - err = -EINVAL; - goto out_iounmap_regs; + return -EINVAL; } fdev->chan[chan->id] = chan;@@ -1192,17 +1189,12 @@ static int fsl_dma_chan_probe(struct fsldma_device *fdev, chan->irq ? chan->irq : fdev->irq); return 0; - -out_iounmap_regs: - iounmap(chan->regs); - return err; } static void fsl_dma_chan_remove(struct fsldma_chan *chan) { tasklet_kill(&chan->tasklet); list_del(&chan->common.device_node); - iounmap(chan->regs); } static int fsldma_of_probe(struct platform_device *op) --2.54.0