Re: [PATCH v2] scsi: core: Remove remaining references to the pktcdvd driver
From: John Garry <john.g.garry@oracle.com>
Date: 2026-06-03 15:37:09
Also in:
linux-mips, linux-scsi, linux-sh, lkml, sparclinux
On 03/06/2026 14:27, Catalin Iacob wrote:
Commit 1cea5180f2f8 ("block: remove pktcdvd driver") left behind some
CONFIG_CONFIG_CDROM_PKTCDVD* references in defconfigs and around an
export. Remove them.
Signed-off-by: Catalin Iacob<redacted>
---
Found this incidentally while looking at kernel sources to understand
what pktcdvd is
---
Changes in v2:
- Reworded commit message on John Paul Adrian's suggestion to be about
the removed references not the export symbol
- Link to v1:https://patch.msgid.link/20260530-remove-pktcdvd-references-v1-1-
aa56941d4315@gmail.com
---
arch/mips/configs/fuloong2e_defconfig | 1 -
arch/mips/configs/ip22_defconfig | 1 -
arch/mips/configs/ip27_defconfig | 1 -
arch/mips/configs/ip30_defconfig | 1 -
arch/mips/configs/jazz_defconfig | 1 -
arch/mips/configs/malta_defconfig | 1 -
arch/mips/configs/malta_kvm_defconfig | 1 -
arch/mips/configs/maltaup_xpa_defconfig | 1 -
arch/mips/configs/rm200_defconfig | 1 -
arch/mips/configs/sb1250_swarm_defconfig | 1 -
arch/powerpc/configs/g5_defconfig | 1 -
arch/powerpc/configs/ppc6xx_defconfig | 1 -
arch/sh/configs/sh2007_defconfig | 1 -
arch/sparc/configs/sparc64_defconfig | 2 --Obviously none of the changes above are related to scsi core, so they can be made separately
quoted hunk ↗ jump to hunk
drivers/scsi/scsi_lib.c | 8 -------- 15 files changed, 23 deletions(-)diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 85eef401925a..b67f0dc79499 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c@@ -2224,14 +2224,6 @@ struct scsi_device *scsi_device_from_queue(struct request_queue *q) return sdev; } -/* - * pktcdvd should have been integrated into the SCSI layers, but for historical - * reasons like the old IDE driver it isn't. This export allows it to safely - * probe if a given device is a SCSI one and only attach to that. - */ -#ifdef CONFIG_CDROM_PKTCDVD_MODULE -EXPORT_SYMBOL_GPL(scsi_device_from_queue); -#endif
I also think that the prototype of scsi_device_from_queue can be relocated from include/scsi/scsi_device.h to drivers/scsi/scsi_priv.h
/** * scsi_block_requests - Utility function used by low-level drivers to prevent