Re: [PATCH 5/8] mm/bootmem_info: stop marking the pgdat as NODE_INFO
From: Michal Hocko <mhocko@suse.com>
Date: 2026-05-12 07:45:20
Also in:
linux-mm, linux-s390, lkml, sparclinux
On Mon 11-05-26 16:05:33, David Hildenbrand wrote:
We removed the last user of NODE_INFO in commit 119c31caa59e ("mm/sparse:
remove !CONFIG_SPARSEMEM_VMEMMAP leftovers for CONFIG_MEMORY_HOTPLUG").
But it really was never used it besides for safety-checks ever since it was
introduced in commit 04753278769f ("memory hotplug: register section/node
id to free"), where we had the comment:
5) The node information like pgdat has similar issues. But, this
will be able to be solved too by this.
(Not implemented yet, but, remembering node id in the pages.)
Of course, that never happened, and we are not planning on freeing the
node data (pgdat/pglist_data), during memory hotunplug.
So let's just stop marking the pgdat as NODE_INFO.With the last user, shouldn't we simply drop NODE_INFO?
quoted hunk ↗ jump to hunk
Signed-off-by: David Hildenbrand (Arm) <david@kernel.org> --- mm/bootmem_info.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)diff --git a/mm/bootmem_info.c b/mm/bootmem_info.c index 74c1116626c8..cce1d560f094 100644 --- a/mm/bootmem_info.c +++ b/mm/bootmem_info.c@@ -62,15 +62,8 @@ static void __init register_page_bootmem_info_section(unsigned long start_pfn) void __init register_page_bootmem_info_node(struct pglist_data *pgdat) { - unsigned long i, pfn, end_pfn, nr_pages; + unsigned long pfn, end_pfn; int node = pgdat->node_id; - struct page *page; - - nr_pages = PAGE_ALIGN(sizeof(struct pglist_data)) >> PAGE_SHIFT; - page = virt_to_page(pgdat); - - for (i = 0; i < nr_pages; i++, page++) - get_page_bootmem(node, page, NODE_INFO); pfn = pgdat->node_start_pfn; end_pfn = pgdat_end_pfn(pgdat);-- 2.43.0
-- Michal Hocko SUSE Labs